build: Port micromamba-feedstock flags in micromamba's CMakeLists.txt
#3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://github.com/conda-forge/micromamba-feedstock/blob/898f0787101ef08738bf411b82a5b1baad56e801/recipe/build.sh#L3-L14 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Likely a mistake. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
changed the title
micromamba-feedstock flags heremicromamba-feedstock flags in micromamba's CMakeLists.txt
anutosh491
reviewed
Oct 17, 2024
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${frameworks_flags}") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${frameworks_flags}") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Wait shouldn't this be propagated from libmamba/CMakeLists.txt itself ?
We technically need these flags to have a clean build for libmamba.a (first followed by micromamba)
So I would still end up with.
[ 86%] Linking CXX static library libmamba.a
Error running link command: name too longmake[2]: *** [libmamba/libmamba.a] Error 2
There was a problem hiding this comment.
It would be better to scope them for libmamba.a, indeed.
There was a problem hiding this comment.
Could you continue this PR and iterate on a solution?
There was a problem hiding this comment.
BTW you should prefer target_compile_options to global cmake flags. By setting them as public on the target libmamba, they will automagically propagate to the target linking with libmamba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the flags on the feedstock.