Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix micromamba activate on Windows #3484

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix micromamba activate on Windows #3484

merged 1 commit into from
Sep 30, 2024

Conversation

JohanMabille
Copy link
Member

@JohanMabille JohanMabille commented Sep 30, 2024 •
edited
Loading

This fixes the micromamba activate issue we see on CI on Windows.

@JohanMabille JohanMabille marked this pull request as ready for review September 30, 2024 12:56
@JohanMabille JohanMabille changed the title Checks Autorun key Fix micromamba activate on Windows Sep 30, 2024
@JohanMabille JohanMabille added the release::bug_fixes For PRs fixing bugs label Sep 30, 2024
jjerphan
jjerphan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also fix #3475?

@JohanMabille
Copy link
Member Author

It should, but I prefer to get confirmation from Ondrej when micromamba 2.0.1 is out before closing it.

@JohanMabille JohanMabille merged commit 2e8b3ee into mamba-org:main Sep 30, 2024
32 of 33 checks passed
@JohanMabille JohanMabille deleted the windows_activate branch September 30, 2024 14:06
@JohanMabille JohanMabille mentioned this pull request Oct 1, 2024
Closed
@jeremyleung521 jeremyleung521 mentioned this pull request Oct 1, 2024
Open
@anutosh491
Copy link

It should, but I prefer to get confirmation from Ondrej when micromamba 2.0.1 is out before closing it.

I tried unpinning the micromamba version (lfortran had pinned it to '1.5.10-0') just to check this and I think the issue still persists (https://github.com/lfortran/lfortran/actions/runs/11160498346/job/31021087727?pr=4963)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan approved these changes

@Hind-M Hind-M Hind-M approved these changes

Assignees
No one assigned
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohanMabille @anutosh491 @jjerphan @Hind-M