Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test in osx #3448

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix test in osx #3448

merged 1 commit into from
Sep 17, 2024

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Sep 16, 2024

No description provided.

@Hind-M Hind-M added the release::bug_fixes For PRs fixing bugs label Sep 16, 2024
@JohanMabille
Copy link
Member

We may want to either be able to set one of these two variables depending on what we want to test locally, or to skip this test for micromamba, but let's do that later.

@Hind-M
Copy link
Member Author

Hind-M commented Sep 17, 2024

We may want to either be able to set one of these two variables depending on what we want to test locally, or to skip this test for micromamba, but let's do that later.

Hum, not sure this is doable in a clean way, since we use TEST_MAMBA_EXE as the executable, but that doesn't give a clear info about which one is used (mamba or micromamba) unless we check that the filename in TEST_MAMBA_EXE is mamba or not?...

@Hind-M Hind-M marked this pull request as ready for review September 17, 2024 10:28
@JohanMabille
Copy link
Member

not sure this is doable in a clean way,

Me neither, but this can wait for after the release.

@JohanMabille JohanMabille merged commit b08d40d into mamba-org:main Sep 17, 2024
32 checks passed
@Hind-M Hind-M deleted the osx_test branch September 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants