fix: PyPI support for env update
#3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
force-pushed
the
fix/pip-support-for-env-update
branch
from
4bc9e04
to
5e46173
Compare
jjerphan
force-pushed
the
fix/pip-support-for-env-update
branch
from
b9cc118
to
6efaf64
Compare
jjerphan
force-pushed
the
fix/pip-support-for-env-update
branch
from
6efaf64
to
42771f2
Compare
Hind-M
reviewed
Aug 30, 2024
|
Can we also add tests to make sure we are behaving like |
Hind-M
reviewed
Sep 3, 2024
Hind-M
reviewed
Sep 3, 2024
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Hind Montassif <hind.montassif@gmail.com>
Hind-M
force-pushed
the
fix/pip-support-for-env-update
branch
from
35a15d1
to
90ad1c3
Compare
JohanMabille
approved these changes
Sep 5, 2024
|
🎉 |
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #1455.
This factors the logic of the call to
pipfor the install and update path.Note that previously the output of
pip installwas redirected up to thelibmambapyhelpers' outputs, breaking JSON outputs when--jsonis specify. The logging level aren't managing the standard output of subprocess for now, and doing this properly probably should be done in another PR. For now, we simply callpipin quiet mode.