Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[micromamba] Fix behavior of env update (to mimick conda) #3396

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[micromamba] Fix behavior of env update (to mimick conda) #3396

merged 2 commits into from
Aug 8, 2024

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Aug 6, 2024

Fix #3388

@Hind-M Hind-M added the release::bug_fixes For PRs fixing bugs label Aug 6, 2024
@Hind-M Hind-M requested a review from Klaim August 6, 2024 09:03
Klaim
Klaim reviewed Aug 6, 2024
View reviewed changes
libmamba/include/mamba/api/update.hpp Outdated Show resolved Hide resolved
libmamba/src/api/update.cpp Show resolved Hide resolved
micromamba/src/env.cpp Outdated Show resolved Hide resolved
micromamba/tests/test_env.py Show resolved Hide resolved
@Hind-M
Code review:
f091b91 
Use struct and enum class for update parameters
Klaim
Klaim approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@Hind-M Hind-M mentioned this pull request Aug 8, 2024
Open
@Hind-M Hind-M merged commit d17ebc5 into mamba-org:main Aug 8, 2024
32 checks passed
@Hind-M Hind-M mentioned this pull request Aug 8, 2024
Closed
@Hind-M Hind-M deleted the env_update branch August 8, 2024 10:09
@jjerphan jjerphan mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaim Klaim Klaim approved these changes

Assignees
No one assigned
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

micromamba env update behavior different from conda
2 participants
@Hind-M @Klaim