Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Context with Context::platform where possible #3364

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Replace Context with Context::platform where possible #3364

merged 1 commit into from
Jul 29, 2024

Conversation

jjerphan
Copy link
Member

No description provided.

@jjerphan
Replace Context with Context::platform where possible
296cefc 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the replace_context_with_platform branch from 660e23d to 296cefc Compare July 26, 2024 14:30
jjerphan
jjerphan commented Jul 26, 2024
View reviewed changes
libmamba/include/mamba/core/virtual_packages.hpp
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this header public?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it yes.

@jjerphan jjerphan marked this pull request as ready for review July 26, 2024 15:23
@Hind-M Hind-M added the release::enhancements For enhancements PRs or implementing features label Jul 29, 2024
@Hind-M Hind-M merged commit 154012f into mamba-org:main Jul 29, 2024
32 of 33 checks passed
@jjerphan jjerphan deleted the replace_context_with_platform branch July 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hind-M Hind-M Hind-M approved these changes

Assignees
No one assigned
Labels
release::enhancements For enhancements PRs or implementing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjerphan @Hind-M