maint: Remove PrefixData::load

[jjerphan]

Merge its content within PrefixData::PrefixData.

[Hind-M]

We should remove this as well.

[jjerphan]

Yes, I probably should have kept this PR in Draft.

There's the same pattern with SubdirData:

mamba/libmamba/src/core/subdirdata.cpp

Line 594 in 3e1e97b

SubdirData::load(MultiPackageCache& caches, ChannelContext& channel_context, const specs::Channel& channel)

[Hind-M]

IMHO, I think we should keep them all, since it's kind of separating the logic and it's easier to read (better that blocks of code at once). And it's not like it's defined somewhere far away in the codebase or in another file... It's just the method right below...

[jjerphan]

PrefixData::load only was called once in the constructor, in that case I think it would have made sense to merge it to prevent any misuse. No strong opinion.

Do you propose reverting the merge commit?

[Hind-M]

No strong opinion either, I was just expressing mine ^^

Do you propose reverting the merge commit?

Either that or removing the leftover in the header. But for SubdirData, I would keep it the way it is.

[jjerphan]

I just have opened #3325.