Move GHA to setup-micromamba #2545
Conversation
AntoinePrv
force-pushed
the
ci-setup-micromamba
branch
from
6498406
to
1bb6ab3
Compare
AntoinePrv
force-pushed
the
ci-setup-micromamba
branch
2 times, most recently
from
2fb8f62
to
f669fa5
Compare
AntoinePrv
force-pushed
the
ci-setup-micromamba
branch
from
0d0d2b2
to
fcba7b1
Compare
|
Thanks for fixing what I gave up on! |
| extra-specs: menuinst | ||
|
|
||
| create-args: menuinst | ||
| init-shell: bash cmd.exe powershell |
There was a problem hiding this comment.
Setting init-shell: none could also be an option. This would then definitely not interfere with the shell initialization tests...
We would then need to activate the micromamba environment by hand or call micromamba run -n ...
There was a problem hiding this comment.
I think when init-shell was not used, the shell was not finding micromamba executable
There was a problem hiding this comment.
Yes, this is because the micromamba executable is not on PATH. You could add it to PATH manually beforehand:
- name: Add micromamba to GITHUB_PATH
run: echo "${HOME}/micromamba-bin" >> "$GITHUB_PATH"There was a problem hiding this comment.
provision-with-micromamba did the shell initialization thing for every shell that was on the system. setup-micromamba allows you to specify the shell and also gives you the option to do the initialization for no shell at all. I think this would be the option that makes the most sense for shell init tests.
There was a problem hiding this comment.
May I lobby for #2577
There was a problem hiding this comment.
provision-with-micromamba did the shell initialization thing for every shell that was on the system. setup-micromamba allows you to specify the shell and also gives you the option to do the initialization for no shell at all. I think this would be the option that makes the most sense for shell init tests.
I agree this would be better, but I'm also afraid by potential issues this could lead to and the time it would take to fix them. Let's merge this one since it passes the, and and tackle this in a dedicated PR.
|
LGTM, I think all of the |
No description provided.