Skip to content

Commit

Permalink
fixes all publish warnings (RevenueCat#161)
Browse files Browse the repository at this point in the history
  • Loading branch information
vegaro authored Mar 3, 2021
1 parent 4ae7cdd commit e26ffd0
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 13 deletions.
File renamed without changes.
2 changes: 1 addition & 1 deletion RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
1. Update to the latest SDK versions in purchases_flutter.podspec and build.gradle.
1. Run `flutter format .`
1. Update versions in VERSIONS.md.
1. Update CHANGELOG.latest.md with the changes for the current version (to be used by Fastlane for the github release notes)
1. Update CHANGELOG-LATEST.md with the changes for the current version (to be used by Fastlane for the github release notes)
1. Run `bundle exec fastlane bump_and_update_changelog version:X.Y.Z` (where X.Y.Z is the new version) to update the version number in pubspec.yaml, purchases_flutter.podspec and android/build.gradle.
1. `flutter pub pub publish --dry-run`
1. `git commit -am "Preparing for version x.y.z"`
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ platform :android do
end

def attach_changelog_to_master
current_changelog = File.open("../CHANGELOG.latest.md", 'r')
current_changelog = File.open("../CHANGELOG-LATEST.md", 'r')
master_changelog = File.open("../CHANGELOG.md", 'r')

current_changelog_data = current_changelog.read
Expand Down
1 change: 0 additions & 1 deletion lib/entitlement_info_wrapper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ enum PeriodType {

/// If the period type couldn't be determined.
unknown

}

/// Enum of supported stores
Expand Down
4 changes: 2 additions & 2 deletions lib/offering_wrapper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ class Offering {
/// Retrieves a specific package by identifier, use this to access custom
/// package types configured in the RevenueCat dashboard.
Package? getPackage(String identifier) {
return availablePackages.firstWhereOrNull(
(package) => package.identifier == identifier);
return availablePackages
.firstWhereOrNull((package) => package.identifier == identifier);
}

@override
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ documentation: https://docs.revenuecat.com/docs

environment:
sdk: '>=2.12.0 <3.0.0'
flutter: ">=1.12.13+hotfix.6 <2.0.0"
flutter: ">=1.12.13+hotfix.6"

dependencies:
flutter:
sdk: flutter
collection: ^1.15.0-nullsafety.4
collection: ^1.15.0

dev_dependencies:
pedantic: ^1.8.0
Expand Down
12 changes: 6 additions & 6 deletions test/entitlement_info_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ void main() {
"unsubscribeDetectedAt": null,
"unsubscribeDetectedAtMillis": null,
"billingIssueDetectedAt": null,
"billingIssueDetectedAtMillis": null};
final entitlementInfo =
EntitlementInfo.fromJson(entitlementInfoJson);
"billingIssueDetectedAtMillis": null
};
final entitlementInfo = EntitlementInfo.fromJson(entitlementInfoJson);

expect(entitlementInfo.periodType, PeriodType.unknown);
});
Expand All @@ -43,9 +43,9 @@ void main() {
"unsubscribeDetectedAt": null,
"unsubscribeDetectedAtMillis": null,
"billingIssueDetectedAt": null,
"billingIssueDetectedAtMillis": null};
final entitlementInfo =
EntitlementInfo.fromJson(entitlementInfoJson);
"billingIssueDetectedAtMillis": null
};
final entitlementInfo = EntitlementInfo.fromJson(entitlementInfoJson);

expect(entitlementInfo.store, Store.unknownStore);
});
Expand Down

0 comments on commit e26ffd0

Please sign in to comment.