Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak handling of missing } #1985

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Tweak handling of missing } #1985

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8943574
remove m4 filter shortcut
mtoy-googly-moogly Oct 29, 2024
3673fd7
Merge branch 'main' into close-curly-full-commitment
mtoy-googly-moogly Dec 31, 2024
fee54de
remove tests too
mtoy-googly-moogly Dec 31, 2024
d9dfd63
Update usage of closeCurly
mtoy-googly-moogly Dec 31, 2024
f19ac3f
fix another test
mtoy-googly-moogly Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove tests too
  • Loading branch information
@mtoy-googly-moogly
mtoy-googly-moogly committed Dec 31, 2024
commit fee54dec308bcdab4fe6da9974e11b7beed82435
22 changes: 0 additions & 22 deletions packages/malloy/src/lang/test/source.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,6 @@ describe('source:', () => {
"source: xA is _db_.table('aTable') extend { where: astr ~ 'a%' }"
).toTranslate();
});
test('shorcut fitlered table m4warning', () => {
expect(`
##! m4warnings=warn
source: xA is _db_.table('aTable') extend {? astr ~ 'a%' }
`).toLog(
warningMessage(
'Filter shortcut `{? condition }` is deprecated; use `{ where: condition } instead'
)
);
});
test('fitlered table', () => {
expect(
"source: testA is _db_.table('aTable') extend { where: astr ~ 'a%' }"
Expand Down Expand Up @@ -558,18 +548,6 @@ describe('source:', () => {
}
`).toTranslate();
});
test('refined explore-query m4warning', () => {
expect(`
##! m4warnings=warn
source: abNew is ab extend {
view: for1 is aturtle + {? ai = 1 }
}
`).toLog(
warningMessage(
'Filter shortcut `{? condition }` is deprecated; use `{ where: condition } instead'
)
);
});
test('chained explore-query', () => {
expect(`
source: c is a extend {
Expand Down
Loading