Skip to content

Fixes a retain cycle occuring in Debouncer callback #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malcommac merged 1 commit into from
Jul 16, 2018
Merged

Fixes a retain cycle occuring in Debouncer callback #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Repeat/Debouncer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ open class Debouncer {
/// Multiple calls will ignore the older calls and overwrite the firing time.
public func call() {
if self.timer == nil {
self.timer = Repeater.once(after: self.delay, { _ in
guard let callback = self.callback else {
self.timer = Repeater.once(after: self.delay, { [weak self] _ in
guard let callback = self?.callback else {
debugPrint("Debouncer fired but callback not set.")
return
}
Expand Down