Test: Test PR change #244
Open
Test: Test PR change #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current contribution flow requires a `push` label for a pull request to be merged. Only a user with write access can add the `push` label such as a maintainer. However, the `push` label is "sticky" and stays on the pull request from that point on. It was recently decided that the user adding the push label should always have to explicitly do so prior to merge. If a pull request is updated (by the PR author or, simply with a rebase), someone must reverify the contents and add the `push` label again. This means `push` labels will need to be added much more often to PRs. This prevents a "time-of-check-time-of-merge" torn state in the pull request contribution flow. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
add_reset_push_label_gh_workflow_test_pr
branch
from
ef78bea to
4a6c6ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR change