changes on the index.js starting script #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makinhs
requested changes
May 26, 2021
There was a problem hiding this comment.
Hi @Jopchumba , thanks for the pull-request and sorry for the late reply...
What about just hiding the X-Powered-By as helmet suggests?
If you are willing to add it:
http://expressjs.com/en/advanced/best-practice-security.html#use-helmet
https://www.npmjs.com/package/helmet
app.use(helmet.hidePoweredBy())
Helmet will provide the x-powered-by solution + a few other security wise solutions.
If you are keen to add it I will accept the pull request
Thanks in advance,
|
X-Powered-by is a legacy thing, best to keep it out completely. This was stated in my CEH course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a minor tweak on the response header X-POWERED by to a user set ie rainbows or any other string for security purposes.