fix content disposition response header (#38)

makinacorpus · Dec 7, 2023 · 57ce5b6 · 57ce5b6
1 parent 468b777
commit 57ce5b6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -9,6 +9,7 @@ CHANGELOG
 - Update Docker image to ubuntu 22.04 base
 - Use directly libreoffice instead of deprecated unoconv
 - Move CI to github-action
+- Fix typo in attachment response Content-Disposition (#38)
 
 
 2.2.5 (2021-01-13)

diff --git a/README.rst b/README.rst
@@ -32,7 +32,7 @@ Example, convert from *odt* to *pdf* :
 
     curl http://convertit/?url=http://server/document.odt&to=application/pdf
     HTTP/1.1 302 Found
-    Content-Disposition: attachement; filename=document.pdf
+    Content-Disposition: attachment; filename=document.pdf
     ...
 
 GET parameters:
@@ -57,7 +57,7 @@ Upload data in POST parameter named ``file``:
 
     curl -F "file=@tiger.svg" http://convertit/?to=image/png
     HTTP/1.1 302 Found
-    Content-Disposition: attachement; filename=tiger.png
+    Content-Disposition: attachment; filename=tiger.png
 
 
 

diff --git a/convertit/views.py b/convertit/views.py
@@ -164,5 +164,5 @@ def home_view(request, input_filepath, output_basename_generator):
                                        content_type='text/plain')
 
     return HTTPFound(static_url(output_filepath, request),
-                     content_disposition='attachement; filename=%s' %
+                     content_disposition='attachment; filename=%s' %
                      output_basename)