Marker does not snap to polyline using latest Leaflet.draw

[albhardy]

Thanks for the great plugin! I'm using the library to snap new marker drawn into polylines.
However, when I updated Leaflet.draw library from https://github.com/Leaflet/Leaflet.draw - snap marker no longer works. It stops working from Leaflet.draw 0.2.3-dev commit: c214aebffde9 onwards (Compatible up to commit: 76e1beaa92)

[cgwyllie]

Hi, I encountered this issue as well, here's what I could find out.

Snap uses the edit feature 'enabled' event to initialise the snapping:
https://github.com/makinacorpus/Leaflet.Snap/blob/gh-pages/leaflet.snap.js#L167

In Leaflet.Draw between those commits, the order the 'enabled' event is fired was changed from before the constructor call to after.

Version 0.2.2: https://github.com/Leaflet/Leaflet.draw/blob/0.2.2/dist/leaflet.draw-src.js#L125

Version 0.2.3: https://github.com/Leaflet/Leaflet.draw/blob/0.2.3/dist/leaflet.draw-src.js#L129

This causes the test in https://github.com/makinacorpus/Leaflet.Snap/blob/gh-pages/leaflet.snap.js#L176 to fail, aborting initialisation of the snapping behaviour.

Not sure how best to resolve, but I made a quick hack to confirm it's an initialisation order problem. If you patch Leaflet.Snap like so, it starts working again:

L.Draw.Feature.SnapMixin = {
    _snap_initialize: function () {
        var _this = this;
        this.on('enabled', function () {
            var args = arguments;
            setTimeout(function () {
                _this._snap_on_enabled.apply(_this, args);
            }, 0);
        });
        this.on('disabled', this._snap_on_disabled, this);
    },
    ...

Does anyone have a good idea how to resolve this properly?

Thanks!

[Lambdac0re]

This is the bug they fixed by changing the order:
Leaflet/Leaflet.draw#247
Leaflet/Leaflet.draw@c214aeb

[Lambdac0re]

Fixed now.