Skip to content

fix(activedescendant): rollback scroll logic to use scrollTop#202

Merged
saiponnada merged 1 commit intomasterfrom
scrollto-fix
Feb 27, 2025
Merged

fix(activedescendant): rollback scroll logic to use scrollTop#202
saiponnada merged 1 commit intomasterfrom
scrollto-fix

Conversation

@saiponnada
Copy link
Contributor

Rolled back changes to previous state #175

Context

  • scrollIntoView is causing further issues with dependency libraries like floating-ui. Hence rolling back the changes to use previous implementation using scrollTo instead.
  • Previously this change was made because of the makeup listbox options not being focused when using kb with a long list whereas this was never an issue on ebayui-core.

Changes

  • Roll back changes to use scrollTo instead
  • Updated Listbox code to pass parentElement as container to active-descendant

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@saiponnada saiponnada merged commit 4f1b96b into master Feb 27, 2025
1 check failed
@saiponnada saiponnada deleted the scrollto-fix branch March 17, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants