Skip to content

fix(combobox): remove alwaysFilter option #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianmcburnie merged 1 commit into from
Jan 17, 2025
Merged

fix(combobox): remove alwaysFilter option #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/ui/makeup-combobox/index.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/ui/makeup-combobox/index.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions packages/ui/makeup-combobox/dist/cjs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ const defaultOptions = {
autoSelect: true,
collapseTimeout: 150,
customElementMode: false,
autoScroll: true,
alwaysFilter: true
autoScroll: true
};
class _default {
constructor(widgetEl, selectedOptions) {
Expand Down Expand Up @@ -106,7 +105,9 @@ class _default {
}
exports.default = _default;
function _onInputFocus() {
if (!this._options.alwaysFilter === true) {
if (this._autocompleteType === "list") {
_filterSuggestions(this._inputEl.value, this._listboxWidget.items);
} else {
this.resetFilter();
}
}
Expand Down
7 changes: 4 additions & 3 deletions packages/ui/makeup-combobox/dist/mjs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ const defaultOptions = {
autoSelect: true,
collapseTimeout: 150,
customElementMode: false,
autoScroll: true,
alwaysFilter: true
autoScroll: true
};
class index_default {
constructor(widgetEl, selectedOptions) {
Expand Down Expand Up @@ -104,7 +103,9 @@ class index_default {
}
}
function _onInputFocus() {
if (!this._options.alwaysFilter === true) {
if (this._autocompleteType === "list") {
_filterSuggestions(this._inputEl.value, this._listboxWidget.items);
} else {
this.resetFilter();
}
}
Expand Down
5 changes: 3 additions & 2 deletions packages/ui/makeup-combobox/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const defaultOptions = {
collapseTimeout: 150,
customElementMode: false,
autoScroll: true,
alwaysFilter: true,
};

export default class {
Expand Down Expand Up @@ -123,7 +122,9 @@ export default class {
}

function _onInputFocus() {
if (!this._options.alwaysFilter === true) {
if (this._autocompleteType === "list") {
_filterSuggestions(this._inputEl.value, this._listboxWidget.items);
} else {
this.resetFilter();
}
}
Expand Down
Loading