fix: feedback on layout shift troubleshooting guide #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrata
requested review from
arvinpoddar,
fikrikarim,
jamesqquick and
migueloller
|
One thing that appears to missing is the idea of images causing layout shift. When I hear layout shift that's the first thing I think of. I imagine it's similar for other people. Is it worth titling this to be more specific to address that? Also for the section on pinpointing the problematic update, it would be amazing to have a code snippet if possible for each option. Right off hand, I don't know what would cause Is there also a writeup of the problem(s) that sparked this. I realized I didn't due my diligence of really understanding the issue people were having initially. |
jamesqquick
requested changes
May 8, 2025
|
See #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up for #99 to address feedback from @migueloller
Preview
https://makeswift-sasha-eng-8460-2.mintlify.app/developer/guides/troubleshooting/layout-shift