Cass N - Guardian Digest (partial solution) #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… style, client and view methods constructed
… view displayArticles method built
mirandaweston
left a comment
mirandaweston
left a comment
There was a problem hiding this comment.
Clean, readable code with clear variable names and structure. Love the addition of CSS, would just suggest more exhaustive test coverage.
| @@ -0,0 +1,44 @@ | |||
| h1, p, * { | |||
There was a problem hiding this comment.
nice lil bit of css! wish I'd had the chance to implement ✨
|
|
||
| formatArticles(article) { | ||
| return { | ||
| title: article.webTitle, |
There was a problem hiding this comment.
v readable/clean code, variable names are easy to follow
|
|
||
| /// | ||
|
|
||
| describe('NewsView', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My version of this news aggregator currently retrieves an array of article objects for the UK edition of the Guardian, and renders the headlines for ten most recent results. I have built, but not tested, the logic for a topic search.
I ran into some trouble with testing the mock API call so my test coverage is minimal, and presently I have a bug related to importing the Guardian JS client (per their instructions here: https://github.com/PorterK/GuardianJSClient); two of the test suites won't run due to [SyntaxError: Cannot use import statement outside a module], but this does not stop the program working to its current spec on the front end.
I've done some preliminary CSS design and left relevant comments where I would attempt to improve functionality with more time, and how.