Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1717

Merged
merged 7 commits into from
Jan 30, 2020
Merged

Update dependencies #1717

merged 7 commits into from
Jan 30, 2020

Conversation

jamesjoshuahill
Copy link
Contributor

@jamesjoshuahill jamesjoshuahill commented Jan 27, 2020

Why

Let's update the dependencies to avoid drift.

Let's update the Rubocop rules to remove warnings caused by outdated rules, so that it is easier to get started with Rubocop. Some learners ignore Rubocop because it shows warnings the first time they use it.

Currently, CI is disabled on this repo. Let's remove the unused Rakefile, Travis CI config and misleading mention in the README that checks run on pull requests.

What

  • Bump Ruby to 2.6.5
  • Update Rubocop rules to latest Scaffolint rules
  • Update versions in gem bundle
  • Remove unused Rakefile and Travis CI config
  • Remove mention of checks on pull requests from README

Remove ruby version from Travis CI config, it will use .ruby-version
CI does not run on this repo
@jamesjoshuahill jamesjoshuahill merged commit 7a903d2 into master Jan 30, 2020
@jamesjoshuahill jamesjoshuahill deleted the update-dependencies branch January 30, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant