[Control] Init gui #186
Closed
[Control] Init gui #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello there! Thanks for your PR, it's deeply appreciated as we are in the process of building the control GUI as I write this comment. @valeriansaliou and @BlackYoup will take a look at it 😊 |
|
@ronanM Hello! Sorry for the wait here and thank you very much for this PR. We've been moving on that Control UI part those last few days with some code pushed this afternoon and a new pull request opened to add a few more features (#194). Some of the changes you made are nice but most of them shouldn't apply as the code has been removed. I'll let this PR open if you want to add more changes on top of what we did, feel free to close it otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Control GUI code from a Rust beginner.