Add redirection to documentation #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliottvincent
requested changes
Apr 12, 2020
There was a problem hiding this comment.
Thank you. We may have more docs in the future (mechanical parts, controller software, etc).
So I think it's better to redirect from https://covid-response-projects.github.io/covid-respirator/docs/firmware/ instead.
yannbertrand
force-pushed
the
master
branch
2 times, most recently
from
a8b80e8 to
3ff2124
Compare
|
Thanks for the review. I just updated the PR, lmk if I can change anything else! |
eliottvincent
previously approved these changes
Apr 24, 2020
|
Looks nice now. Could you please resolve the conflicts in |
|
@yannbertrand Our CI "Firmware Documentation" job failed following the merge. The redirection file had a bad extension ( |
|
Sorry about that. Thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled to find the documentation which is on https://covid-response-projects.github.io/covid-respirator/docs/software/firmware/html/files.html.
This PR should add a redirection from https://covid-response-projects.github.io/covid-respirator/docs/ to the real documentation.
May even be better to do it on /covid-respirator/ by removing the
docstarget folder and copy it as well.It should be working as I got the file copied on https://github.com/yannbertrand/covid-respirator/tree/gh-pages/docs 🙂.