Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainnet spell 2024-03-20 #400

Closed
wants to merge 3 commits into from
Closed

Mainnet spell 2024-03-20 #400

wants to merge 3 commits into from

Conversation

SidestreamColdMelon
Copy link
Contributor

Description

This PR implements 2024-03-20 mainnet spell according to the relevant executive sheet

Contribution Checklist

  • Code approved
  • Tests approved
  • CI Tests pass

Checklist

  • Every contract variable/method declared as public/external private/internal
  • Consider if this PR needs the officeHours modifier override
  • Verify expiration (30 days unless otherwise specified)
  • Verify hash in the description matches here
  • Validate all addresses used are in changelog or known
  • Notify any external teams affected by the spell so they have the opportunity to review
  • Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
  • Verify mainnet contract on etherscan
  • Change test to use mainnet spell address and deploy timestamp
  • Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
  • squash and merge this PR

@SidestreamColdMelon SidestreamColdMelon self-assigned this Mar 14, 2024
@SidestreamColdMelon
Copy link
Contributor Author

This PR is closed due to the shifted target date (from 2024-03-20 to 2024-03-26), the new PR can be found here

@SidestreamColdMelon SidestreamColdMelon deleted the 2024-03-20 branch March 19, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant