Skip to content

Commit

Permalink
chore: update checklist related to commit hash
Browse files Browse the repository at this point in the history
  • Loading branch information
SidestreamStrongStrawberry committed Aug 28, 2024
1 parent 0f5c7b5 commit ddd307b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions spell/spell-crafter-mainnet-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] Ensure that executive vote file name and date is correct
* [ ] [community](https://github.com/makerdao/community) repo commit hash corresponds to latest change
* [ ] Raw GitHub URL is correct
* [ ] Raw GitHub URL uses hash of the last commit that introduced a change to Exec Doc
* [ ] Commit hash found above matches the result of `git log --pretty=oneline -1 -- 'PATH_TO_EXEC_DOC'` in the [community](https://github.com/makerdao/community) repo
* [ ] Exec hash is correct (use `cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"` where `wget` doesn't work)
* [ ] Ensure `description` date in `DssSpell.sol` matches target date inside Exec Doc
* [ ] Make sure all review comments are either addressed or explicitly answered
Expand Down
2 changes: 2 additions & 0 deletions spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,8 @@ _Insert your local test logs here_
* [ ] Exec Doc file name follows the format `Executive vote - Month DD, YYYY.md`
* [ ] Extract _permanent_ URL to the raw markdown file and paste it below
_Insert your Raw Exec Doc URL here_
* [ ] Ensure the URL uses hash of the last commit that introduced a change to Exec Doc
* [ ] Commit hash found above matches the result of `git log --pretty=oneline -1 -- 'PATH_TO_EXEC_DOC'` in the [`makerdao/community` GitHub repo](https://github.com/makerdao/community)
* [ ] Using Exec Doc URL from the above and the `TARGET_DATE`, generate Exec Doc Hash via `make exec-hash date=$TARGET_DATE $URL`
_Insert your Exec Doc Hash here_
* [ ] Using Exec Doc URL from the above, generate Exec Doc Hash via `cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"`
Expand Down

0 comments on commit ddd307b

Please sign in to comment.