-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[SECUR-105] fix: csv injection vulnerability sanitization #8611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sangeethailango
wants to merge
1
commit into
preview
Choose a base branch
from
fix-csv-injection-on-export-files
base: preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # CSV utility functions for safe export | ||
|
|
||
| # Characters that trigger formula evaluation in spreadsheet applications | ||
| _CSV_FORMULA_TRIGGERS = frozenset(("=", "+", "-", "@", "\t", "\r", "\n")) | ||
|
|
||
|
|
||
| def sanitize_csv_value(value): | ||
| """Sanitize a value for CSV export to prevent formula injection. | ||
|
|
||
| Prefixes string values starting with formula-triggering characters | ||
| with a single quote so spreadsheet applications treat them as text | ||
| instead of evaluating them as formulas. | ||
|
|
||
| See: https://owasp.org/www-community/attacks/CSV_Injection | ||
| """ | ||
| if isinstance(value, str) and value and value[0] in _CSV_FORMULA_TRIGGERS: | ||
| return "'" + value | ||
| return value | ||
|
|
||
|
|
||
| def sanitize_csv_row(row): | ||
| """Sanitize all values in a CSV row.""" | ||
| return [sanitize_csv_value(v) for v in row] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the standard license header to satisfy the addlicense check.
The pipeline is failing the copyright check; this file is missing the standard header used across the repo.
🧾 Proposed fix
🧰 Tools
🪛 GitHub Actions: Copy Right Check
[error] 1-1: Copyright check failed. The command 'addlicense -check -f COPYRIGHT.txt -ignore "/migrations/" $(git ls-files '*.py')' exited with code 1.
🤖 Prompt for AI Agents