Skip to content

fix: add optional chaining in orderArrayBy to prevent crashes #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: preview
Choose a base branch
from
+8 −2
Open

fix: add optional chaining in orderArrayBy to prevent crashes #8080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0381f7
fix: add optional chaining in orderArrayBy to prevent crashes
hamed-zeidabadi Nov 7, 2025
76df866
fix: handle null/undefined values in orderArrayBy with proper fallback
hamed-zeidabadi Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/utils/src/array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,14 @@ export const orderArrayBy = (orgArray: any[], key: string, ordering: "ascending"
const innerKey = key.split("."); // split the key by dot

return array.sort((a, b) => {
const keyA = innerKey.reduce((obj, i) => obj[i], a); // get the value of the inner key
const keyB = innerKey.reduce((obj, i) => obj[i], b); // get the value of the inner key
const keyA = innerKey.reduce((obj, i) => obj?.[i], a); // get the value of the inner key
const keyB = innerKey.reduce((obj, i) => obj?.[i], b); // get the value of the inner key

// Handle undefined/null values - push them to the end
if (keyA == null && keyB == null) return 0;
if (keyA == null) return 1;
if (keyB == null) return -1;

if (keyA < keyB) {
return ordering === "ascending" ? -1 : 1;
}
Expand Down