fix: CI to include lint and format #7482

aheckmann · 2025-07-25T15:24:29Z

Description

Get editor lint check passing again
Move lint step first during CI
Include formatting of the files

Type of Change

Bug fix (non-breaking change which fixes an issue)
Code refactoring

Summary by CodeRabbit

Chores
- Updated the build and lint workflow for web apps, adjusting the order and commands used for building and linting.
- Added a new build script to streamline continuous integration processes.
Style
- Improved code consistency by updating import paths for icons in the table extension.

The web app takes too long and causes CI to timeout. Once we improve we will reintroduce.

coderabbitai · 2025-07-25T15:24:38Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between c43017e and 5f79d59.

📒 Files selected for processing (27)

.github/workflows/pull-request-build-lint-web-apps.yml (2 hunks)
apps/admin/.prettierignore (1 hunks)
apps/space/.prettierignore (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/browse/[workItem]/header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/drafts/header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/extended-project-sidebar.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/extended-sidebar.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/profile/[userId]/header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/profile/[userId]/mobile-header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/archives/header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/archives/issues/(detail)/[archivedIssueId]/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/cycles/(detail)/[cycleId]/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/cycles/(list)/header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/cycles/(list)/mobile-header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/draft-issues/header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/intake/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/issues/(list)/mobile-header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(detail)/[moduleId]/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(detail)/mobile-header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(list)/header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(list)/mobile-header.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(list)/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(list)/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/page.tsx (1 hunks)
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(list)/header.tsx (1 hunks)

 ______________________________________________________________________________________________________
< My code reviews are like a Tesla: fully electric, increasingly autonomous, and occasionally on fire. >
 ------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

The updates introduce a new npm script for CI builds, adjust the GitHub Actions workflow to use this script and reorder linting and build steps, and correct an import path in a TypeScript file. No changes were made to exported or public entities beyond the new script.

Changes

File(s)	Change Summary
.github/workflows/pull-request-build-lint-web-apps.yml	Replaced "Build web apps" step with "Build apps" using `ci:build`; reordered lint and build steps.
package.json	Added `ci:build` script for Turbo build excluding `web`; minor formatting change.
packages/editor/src/core/extensions/table/table/table-view.tsx	Changed import path for `icons` from absolute to relative.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

In the warren, scripts now hop anew,
CI builds with Turbo, skipping web as it’s due.
Linting leads the way,
While imports find their stay—
A bunny’s tidy update, swift and true!
🐇✨

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting in your project's settings in CodeRabbit to disable the poems in the walkthrough.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore-ci_lint_first

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

package.json (1)

19-21: ci:build script added – confirm the filter behaves as expected

turbo run build --filter=!web will skip the web workspace only if no downstream projects depend on it.
If any package depends on web, Turbo will still build it.
Double-check the dependency graph; if you truly need to force-skip the build you may have to move web into an ignored scope or adjust the pipeline.
.github/workflows/pull-request-build-lint-web-apps.yml (1)
40-41: Step name no longer reflects what’s built

The job is titled “Build and lint web apps”, yet the new command excludes web.
Consider renaming the step (and possibly the workflow) to avoid misleading status checks while the exclusion is in place.
-      - name: Build apps
+      - name: Build (excluding web)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5f3bd1 and c43017e.

📒 Files selected for processing (3)

.github/workflows/pull-request-build-lint-web-apps.yml (1 hunks)
package.json (1 hunks)
packages/editor/src/core/extensions/table/table/table-view.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Build and lint web apps
GitHub Check: Analyze (javascript)
GitHub Check: Build and lint web apps

🔇 Additional comments (1)

packages/editor/src/core/extensions/table/table/table-view.tsx (1)

7-9: Import-path fix verified: icons.ts is present

Confirmed packages/editor/src/core/extensions/table/table/icons.ts exists alongside table-view.tsx.

The switch to the local ./icons import is safe and will resolve correctly at runtime. 👍

…nt_first

aheckmann added 3 commits July 25, 2025 08:15

fix(lint): get ci passing again

dd58b5b

chore(ci): run lint before build

4a6a327

chore(ci): exclude web app from build check for now

c43017e

The web app takes too long and causes CI to timeout. Once we improve we will reintroduce.

aheckmann requested a review from sriramveeraghanta July 25, 2025 15:24

coderabbitai bot reviewed Jul 25, 2025

View reviewed changes

sriramveeraghanta added 3 commits August 18, 2025 20:16

Merge branch 'preview' of github.com:makeplane/plane into chore-ci_li…

e968673

…nt_first

fix: formating of files

5f79d59

fix: adding format to ci

c8c4a2a

sriramveeraghanta approved these changes Aug 18, 2025

View reviewed changes

sriramveeraghanta merged commit d8f58d2 into preview Aug 18, 2025
3 of 5 checks passed

sriramveeraghanta deleted the chore-ci_lint_first branch August 18, 2025 15:57

sriramveeraghanta changed the title ~~CI fixes~~ fix: CI to include lint and format Aug 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: CI to include lint and format #7482

fix: CI to include lint and format #7482

Uh oh!

aheckmann commented Jul 25, 2025 •

edited by sriramveeraghanta

Loading

Uh oh!

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

fix: CI to include lint and format #7482

fix: CI to include lint and format #7482

Uh oh!

Conversation

aheckmann commented Jul 25, 2025 • edited by sriramveeraghanta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aheckmann commented Jul 25, 2025 •

edited by sriramveeraghanta

Loading

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)