Skip to content

[WEB-3766] fix: user avatar in description version history dropdown item #6888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

[WEB-3766] fix: user avatar in description version history dropdown item #6888

merged 3 commits into from
Apr 8, 2025

Conversation

aaryan610
Copy link
Member

@aaryan610 aaryan610 commented Apr 8, 2025 •
edited by coderabbitai bot
Loading

Description

This PR fixes the following bugs-

  1. Avatar not rendering in the dropdown.
  2. Updated the width of the modal to match the create work item modal's width.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • New Features
    • Improved avatar image handling ensures reliable display even when image sources are missing or incomplete.
    • Updated modal presentation now features a consistent extra-wide layout for a better visual experience.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 8, 2025 •
edited
Loading

Walkthrough

This update modifies two components within the description versions module. Both changes now process avatar URLs using the getFileURL utility from @plane/utils, replacing direct URL usage. Additionally, the modal component now sets its width via the EModalWidth.XXXXL enum imported from @plane/ui. The internal component structure remains the same while the changes enhance URL handling and modal styling.

Changes

Files Change Summary
web/core/components/core/description-versions/dropdown-item.tsx Added import of getFileURL and updated the Avatar's src property to use getFileURL(versionCreator?.avatar_url ?? "").
web/core/components/core/description-versions/modal.tsx Added imports for EModalWidth and getFileURL. Updated the ModalCore component to set its width using EModalWidth.XXXXL and modified the Avatar's src to utilize getFileURL.

Sequence Diagram(s)

sequenceDiagram
    participant DD as Dropdown Component
    participant GF as getFileURL Utility
    participant AV as Avatar Component

    DD->>GF: Call getFileURL(versionCreator?.avatar_url ?? "")
    GF-->>DD: Return processed URL
    DD->>AV: Supply processed URL to Avatar's src
Loading 
sequenceDiagram
    participant M as Modal Component
    participant MC as ModalCore Component
    participant GF as getFileURL Utility
    participant AV as Avatar Component

    M->>MC: Set width using EModalWidth.XXXXL
    M->>GF: Call getFileURL(versionCreator?.avatar_url ?? "")
    GF-->>M: Return processed URL
    M->>AV: Supply processed URL to Avatar's src
Loading

Poem

I hopped through lines of code today,
Fixing URLs in a playful way.
Modal widths set with a gentle hop,
Avatar changes make the code non-stop.
I'm a code bunny, leaping high – no bug can make me sigh!
🐰✨ Happy coding in my burrow of change!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 270f282 and 0242868.

📒 Files selected for processing (2)
  • web/core/components/core/description-versions/dropdown-item.tsx (2 hunks)
  • web/core/components/core/description-versions/modal.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (4)
web/core/components/core/description-versions/dropdown-item.tsx (1)

5-5: Good addition of getFileURL for avatar URL processing

The implementation correctly handles avatar URL processing using the getFileURL utility, which fixes the avatar rendering issue in the dropdown. The null coalescing operator provides an appropriate fallback when avatar_url is null or undefined.

Also applies to: 24-24

web/core/components/core/description-versions/modal.tsx (3)

12-12: Good addition of necessary imports

The imports for EModalWidth and getFileURL provide the necessary utilities to fix the avatar rendering and improve modal sizing.

Also applies to: 20-20

80-80: Good improvement to modal width specification

Using EModalWidth.XXXXL provides better control over the modal size, improving the UI layout and user experience.

88-92: Good implementation of avatar URL handling

The implementation correctly uses getFileURL to process avatar URLs, consistent with the fix in dropdown-item.tsx. This ensures proper rendering of user avatars and handles null/undefined values appropriately.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaryan610 aaryan610 changed the title fix: user avatar in description version history dropdown item [WEB-3766] fix: user avatar in description version history dropdown item Apr 8, 2025
@aaryan610 aaryan610 marked this pull request as ready for review April 8, 2025 12:03
@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend regression labels Apr 8, 2025
@sriramveeraghanta sriramveeraghanta merged commit 08702a5 into preview Apr 8, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/version-history branch April 8, 2025 12:35
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
@aaryan610 @lifeiscontent
[WEB-3766] fix: user avatar in description version history dropdown i…
b8ac912 
…tem (#6888)

* fix: avatar url

* chore: update version modal width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@prateekshourya29 prateekshourya29 prateekshourya29 approved these changes

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaryan610 @sriramveeraghanta @prateekshourya29