[WEB-3449] chore: changed the logic from utc to project date conversion

[NarayanBavisetti]

Description

changed the date check from the UTC timezone to the project timezone.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Issue Link: WEB-3449

Summary by CodeRabbit

• Bug Fixes
  • Enhanced the logic behind time zone conversions to ensure more reliable handling of date transitions. This adjustment improves the accuracy of time-related operations, resulting in more consistent behavior during scenarios involving shifts between local and UTC dates.

[coderabbitai]

Walkthrough

This change updates the conditional check within the convert_to_utc function in the timezone converter utility. Instead of comparing the date of utc_datetime with that of current_datetime_in_utc, it now checks the date of localized_datetime. This modification alters the behavior of the function in determining when to return current_datetime_in_utc.

Changes

File	Change Summary
apiserver/plane/.../timezone_converter.py	Modified the conditional in the convert_to_utc function from comparing utc_datetime's date to comparing localized_datetime's date with current_datetime_in_utc.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant Func as convert_to_utc
    participant LDT as localized_datetime
    participant CDT as current_datetime_in_utc
    participant UDT as utc_datetime

    Caller->>Func: Call convert_to_utc(localized_datetime, utc_datetime, current_datetime_in_utc)
    Func->>Func: Compare LDT.date vs CDT.date
    alt Dates are equal
        Func-->>Caller: Return current_datetime_in_utc
    else Dates differ
        Func-->>Caller: Return utc_datetime
    end

Loading

Possibly related PRs

• [WEB-3177] fix: resolve cycle creation issue for equal start_date and completed_date #6504: Modifies the core logic within convert_to_utc, directly impacting the same area of code.
• [WEB-2843] chore: updated the cycle end date logic #6194: Adjusts the use of convert_to_utc in serializer classes, affecting date processing logic.

Suggested labels

🧹chore, ⚙️backend

Suggested reviewers

• pablohashescobar
• sriramveeraghanta

Poem

I'm a little rabbit, hopped into the code,
Tweaking time zones on a winding road.
With dates and checks all neatly aligned,
A clearer logic now we find.
Keep on hopping, code so bright—
🥕 Cheers to changes done just right!
Happy code trails in the twilight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27cc667 and 9c6ae5f.

📒 Files selected for processing (1)

• apiserver/plane/utils/timezone_converter.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apiserver/plane/utils/timezone_converter.py

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4dd2a6 and 27cc667.

📒 Files selected for processing (1)

• apiserver/plane/utils/timezone_converter.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)