-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: adding secret key variable in newline #5361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adding secret key variable in newline in api server env file and setting default value for `HARD_DELETE_AFTER_DAYS`
WalkthroughRecent updates streamline project configuration and improve script clarity. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- apiserver/.env.example (1 hunks)
- apiserver/bin/docker-entrypoint-api-local.sh (1 hunks)
- setup.sh (1 hunks)
Files skipped from review due to trivial changes (2)
- apiserver/.env.example
- apiserver/bin/docker-entrypoint-api-local.sh
Additional comments not posted (1)
setup.sh (1)
14-14
: Change approved: Ensure newline before appendingSECRET_KEY
.The modification to include a newline before appending the
SECRET_KEY
ensures that it is correctly separated from the previous line in the.env
file, addressing the issue described in the PR summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apiserver/.env.example (1 hunks)
- apiserver/bin/docker-entrypoint-api-local.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- apiserver/bin/docker-entrypoint-api-local.sh
Files skipped from review as they are similar to previous changes (1)
- apiserver/.env.example
When attempting to add a
SECRET_KEY
variable to theapiserver/.env
file, the new key is appended to the end of the previous variable (HARD_DELETE_AFTER_DAYS
), resulting in a single line that incorrectly combines both variables. Additionally, there is a need to ensure that theHARD_DELETE_AFTER_DAYS
variable is set with a default value of60
and that theSECRET_KEY
is added on a new line.Summary by CodeRabbit
New Features
Chores