Support for imagePullSecrets

[michaelfedell]

We often run into rate-limits when pulling images from artifacts.makeplane.so. We would like to override the image for all of our services (as the helm chart already allows us to do) so that we can pull from our own internal mirror and avoid rate limits. However, this requires that we set spec.template.spec.imagePullSecrets on each Deployment resource which is NOT supported by the helm chart values.

It would be great to see support for a global imagePullSecrets value that can reference existing secrets in the cluster.

Currently, we are employing some rather complex mutating admission webhooks to tack on the imagePullSecret but it makes our plane deployment more fragile and less portable.

[mguptahub]

Hello @michaelfedell

To answer your question - Yes you can use your own docker images with provided credentials.

You do not have to worry about spec.template.spec.imagePullSecrets as the helm chart is using ServiceAccount where we are passing the imagePullSecrets

apiVersion: v1
automountServiceAccountToken: true
kind: ServiceAccount
metadata:
  namespace: {{ .Release.Namespace }}
  name: {{ .Release.Name }}-srv-account
{{- if .Values.dockerRegistry.enabled }}
imagePullSecrets:
  - name: {{ .Release.Name }}-docker-registry-credentials
{{- end}}

Hope this clarifies your doubt.