Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated assignmentDetailPage #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ajinkyatalekar
Copy link

Proposed changes


Issue #5: Updated the assignment details page.

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged downstream

Further comments


Added the assignment details page with the required features.

PROBLEMS:
a) I don't know how to decide which assignment to display, so it displays the assignment with id '1' by default.
b) Assignment is accessed by react from an array of length 1 instead of a standalone variable (Because react throws an error about variable could be undefined) . Still works, but needs to be changed.
c) Submit button does nothing currently.

Screenshot 2023-04-27 at 2 14 43 AM

Screenshot 2023-04-27 at 2 35 03 AM

Screenshot 2023-04-27 at 2 40 43 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant