Fix Number.significant to return 0 as is, not as Float64 (cryst…

…al-lang#11321)
makenowjust · Oct 24, 2021 · 0aa45ce · 0aa45ce
1 parent dfa28a4
commit 0aa45ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/spec/std/number_spec.cr b/spec/std/number_spec.cr
@@ -42,6 +42,7 @@ describe "Number" do
     it "preserves type" do
       123.significant(2).should eq(120)
       123.significant(2).should be_a(Int32)
+      0.significant(1).should be_a(Int32)
     end
   end
 

diff --git a/src/number.cr b/src/number.cr
@@ -223,13 +223,10 @@ struct Number
     if digits < 0
       raise ArgumentError.new "digits should be non-negative"
     end
+    return self if zero?
 
     x = self.to_f
 
-    if x == 0
-      return x
-    end
-
     if base == 10
       log = Math.log10(self.abs)
     elsif base == 2