-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webform demo app to /examples #437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronovan
previously approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Co-authored-by: Ron Yehoshua <ron@makenotion.com>
Thanks for the review @ronovan ! Looks like it needs another approval after more commits were added 😇 |
ronovan
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love all the new variable names! ✨
rhart92
pushed a commit
that referenced
this pull request
Oct 3, 2023
* add fullstack webform example app * update package.json detail * make linter happy * delete old folder (name change * Update examples/web-form-with-express/public/client.js Co-authored-by: Ron Yehoshua <ron@makenotion.com> * update var naming for improved readbility * add console back to match appendApiResponse() --------- Co-authored-by: Ron Yehoshua <ron@makenotion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new demo app to the examples directory.
A new draft for the Create an integration guide has been written and approved, which uses this sample code. (It'll be added to Readme after this PR is merged.)
The goal of this demo is to provide some simple webforms that developers can test out to see how user interface interactions can trigger Notion public API requests. Each form returns an ID that can be used in the next form. (e.g. the "create a database" form returns an ID that can be used in the "create a page" form below it.
An extended version of this type of demo would be a blog site that uses Notion as a CMS.