Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webform demo app to /examples #437

Merged
merged 8 commits into from
Aug 14, 2023

Conversation

jessmitch42
Copy link
Contributor

This PR adds a new demo app to the examples directory.

A new draft for the Create an integration guide has been written and approved, which uses this sample code. (It'll be added to Readme after this PR is merged.)

The goal of this demo is to provide some simple webforms that developers can test out to see how user interface interactions can trigger Notion public API requests. Each form returns an ID that can be used in the next form. (e.g. the "create a database" form returns an ID that can be used in the "create a page" form below it.

An extended version of this type of demo would be a blog site that uses Notion as a CMS.
Screen Shot 2023-08-10 at 4 01 52 PM

@jessmitch42 jessmitch42 added the examples Issues related to `examples` label Aug 10, 2023
@jessmitch42 jessmitch42 requested a review from a team August 10, 2023 20:05
@jessmitch42 jessmitch42 self-assigned this Aug 10, 2023
@jessmitch42 jessmitch42 requested review from ronovan and removed request for a team August 10, 2023 20:05
ronovan
ronovan previously approved these changes Aug 12, 2023
Copy link
Contributor

@ronovan ronovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

examples/web-form-with-express/public/client.js Outdated Show resolved Hide resolved
examples/web-form-with-express/public/client.js Outdated Show resolved Hide resolved
examples/web-form-with-express/public/client.js Outdated Show resolved Hide resolved
Co-authored-by: Ron Yehoshua <ron@makenotion.com>
@jessmitch42
Copy link
Contributor Author

Thanks for the review @ronovan ! Looks like it needs another approval after more commits were added 😇

Copy link
Contributor

@ronovan ronovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all the new variable names! ✨

@ronovan ronovan merged commit b71ec28 into makenotion:main Aug 14, 2023
4 checks passed
rhart92 pushed a commit that referenced this pull request Oct 3, 2023
* add fullstack webform example app

* update package.json detail

* make linter happy

* delete old folder (name change

* Update examples/web-form-with-express/public/client.js

Co-authored-by: Ron Yehoshua <ron@makenotion.com>

* update var naming for improved readbility

* add console back to match appendApiResponse()

---------

Co-authored-by: Ron Yehoshua <ron@makenotion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues related to `examples`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants