Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Examples housekeeping tasks #398

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

rhart92
Copy link
Contributor

@rhart92 rhart92 commented Apr 12, 2023

Couple of housekeeping items:

  • Update the SDK version in all example projects
  • Cleaned up some of the example instructions to keep better consistency and easy of setup
  • Migrated email sending example to Typescript 🥳
  • Started migrating templates to a single workspace to make updates easier for the team
  • Fixed a bug in the random data example by adding a rich_text property to the template database.
  • Started adding example.env files which users can rename easily to get the expected environment variables.

@rhart92 rhart92 force-pushed the update-examples-with-new-sdk-version branch 4 times, most recently from 5867148 to 0706be2 Compare April 12, 2023 20:20
@rhart92 rhart92 changed the title Update examples with new SDK version. SDK Examples housekeeping tasks Apr 12, 2023
@rhart92 rhart92 requested review from ronovan and s-h-a-r-c April 12, 2023 20:22
s-h-a-r-c
s-h-a-r-c previously approved these changes Apr 12, 2023
Copy link
Contributor

@s-h-a-r-c s-h-a-r-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This Notion integration sends an email whenever the Status of a page in a database is updated. This sample was built using [this database template](https://www.notion.com/5b593126d3eb401db62c83cbe362d2d5?v=a44397b3675545f389a6f28282c402ae) and emails are sent using [SendGrid's API](https://sendgrid.com).

## Running Locally
This Notion integration sends an email whenever the Status of a page in a database is updated. This sample was built using [this database template](https://public-api-examples.notion.site/0def5dfb6d9b4cdaa907a0466834b9f4?v=aea75fc133e54b3382d12292291d9248) and emails are sent using [SendGrid's API](https://sendgrid.com).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I usually see markdown files set up where each sentence is in a new line, that way if one sentence gets modified within a whole paragraph then it's easier to narrow down the diff. Paragraphs still get separated by line breaks, which is what's already happening.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Divided into 2 lines 👌

@rhart92 rhart92 force-pushed the update-examples-with-new-sdk-version branch from 0706be2 to 29e616d Compare April 12, 2023 20:30
@rhart92 rhart92 enabled auto-merge (squash) April 12, 2023 20:33
Copy link
Contributor

@s-h-a-r-c s-h-a-r-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@rhart92 rhart92 merged commit ab29303 into main Apr 12, 2023
@rhart92 rhart92 deleted the update-examples-with-new-sdk-version branch April 12, 2023 20:36
rhart92 added a commit that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants