Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Conversation

@nisseknudsen
Copy link
Contributor

No description provided.

Added multi subscriber / multi client support
properly using binding for zenoh server and rerun grpc server
Fixed tests structure to avoid duplicate file names
Removed old tests assuming custom error thrown on bound ports
Copilot AI review requested due to automatic review settings October 1, 2025 22:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces multi-subscriber and multi-client functionality to the make87 framework, allowing interfaces to manage multiple subscribers or clients with a single configuration. The implementation includes comprehensive test coverage and is compatible with both Zenoh and Rerun interfaces.

Key changes:

  • Added multi-subscriber and multi-client configuration models with access point mappings
  • Extended interface base classes to support multi-interface types (MSUB, MCLI, PEER)
  • Implemented multi-subscriber and multi-client methods in ZenohInterface and RerunInterface
  • Added binding support for port configuration hierarchy

Reviewed Changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
make87/internal/models/application_env_config.py Added new models for multi-client, multi-subscriber, peer configs, and binding support
make87/interfaces/base.py Extended base interface to support multi-subscriber, multi-client, and peer interface types
make87/interfaces/zenoh/interface.py Implemented multi-subscriber and multi-client methods with proper Zenoh session handling
make87/interfaces/rerun/interface.py Added multi-client recording streams support and port hierarchy configuration
Various test files Comprehensive unit and integration tests for all new functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant