Added query_global_state rpc call #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Bylbas <romka.bulbas@gmail.com>
ihor
reviewed
Jun 29, 2022
| { | ||
| return array( | ||
| 'node_id' => BlockHeaderSerializer::toJson($globalState->getBlockHeader()), | ||
| 'address' => StoredValueSerializer::toJson($globalState->getStoredValue()), |
ihor
requested changes
Jun 29, 2022
Member
ihor
left a comment
ihor
left a comment
There was a problem hiding this comment.
@RomanovSci please check my comments
Signed-off-by: Roman Bylbas <romka.bulbas@gmail.com>
ihor
requested changes
Feb 8, 2023
Member
ihor
left a comment
ihor
left a comment
There was a problem hiding this comment.
@RomanovSci please have a look at my comment
src/Rpc/RpcClient.php
Outdated
| /** | ||
| * @throws RpcError | ||
| */ | ||
| public function getGlobalState(string $blockHash, string $key, array $path = []): GlobalState |
Member
There was a problem hiding this comment.
Let's rename to getGlobalStateByBlock and add another one getGlobalStateByStateRootHash
Member
There was a problem hiding this comment.
In Python SDK they added an abstraction called GlobalStateID:
- https://github.com/casper-network/casper-python-sdk/blob/bb11fa2fa708d17016562152596c71aa4fca9adc/pycspr/types/identifiers.py#L24
- https://github.com/casper-network/casper-python-sdk/blob/bb11fa2fa708d17016562152596c71aa4fca9adc/pycspr/api/client.py#L462
However, with only two possible values, having two separate methods will provide a simpler API for consumers
Signed-off-by: Roman Bylbas <romka.bulbas@gmail.com>
ihor
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Bylbas romka.bulbas@gmail.com
Checklist