-
Notifications
You must be signed in to change notification settings - Fork 982
Add support to casdon 16J3s and T2E #4331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| value: e8 | ||
| - dps_val: e9 | ||
| value: e9 | ||
| - entity: switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a lock entity, which has this translation_key defined (dp name below also needs changing from switch to lock for this)
| value: true | ||
| - entity: select | ||
| class: enum | ||
| name: Work mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave out the name here, and let the translation_key be used instead.
| name: option | ||
| mapping: | ||
| - dps_val: strong | ||
| value: strong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to find similar entries in the existing washing_mode translations first (eg, intensive), if there is really no match, then that list can be extended.
| - dps_val: strong | ||
| value: strong | ||
| - dps_val: quick_wash | ||
| value: quick_wash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rapid
| - dps_val: quick_wash | ||
| value: quick_wash | ||
| - dps_val: "disinfect_wash" | ||
| value: disinfect_wash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self_clean, or hygiene
| type: boolean | ||
| name: sensor | ||
| - entity: sensor | ||
| translation_key: clearing_status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "clearing status" mean exactly?
| "medium_steaming": "Medium Steaming", | ||
| "high_steaming": "High Steaming" | ||
| "high_steaming": "High Steaming", | ||
| "steaming": "Pure Steaming", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one of the other existing steaming options can be used instead of introducing a new translation.
| "high_steaming": "High Steaming" | ||
| "high_steaming": "High Steaming", | ||
| "steaming": "Pure Steaming", | ||
| "high_temperature_steaming": "High Temperature Steaming", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high_temp_steam already exists and can be used instead
| "electrolytic_sterilization": { | ||
| "name": "Electrolytic sterilization" | ||
| }, | ||
| "auto_chucun": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If chucun means storage, then the key should be auto_storage. Otherwise AI will have trouble generating other translations, since the translations are linked to the key.
New device configuration.
Add support to Casdon 16J3s dishwasher and T2E Integrated Stove