-
Notifications
You must be signed in to change notification settings - Fork 941
feat: Add support for Tion Breezer Bio X (9mqdhwklpvnnvb7t) #4137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0d3448a to
c2a2317
Compare
c2a2317 to
56248f3
Compare
| @@ -0,0 +1,237 @@ | |||
| name: Tion Breezer Bio X | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branding should be in the products section (as manufacturer and model tags).
Top level name should be generic in case of other devices matching the same config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
| - id: 9mqdhwklpvnnvb7t | ||
| entities: | ||
| # Main entities | ||
| - entity: switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this device should be a higher level type of device, maybe climate since it has temperature control also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the climate implementation, but found it misleading. It implies the device can control the room's temperature, which it cannot; it only heats the incoming air. This is a secondary function, as the device's main purpose is ventilation.
| type: integer | ||
| unit: "%" | ||
| - entity: sensor | ||
| name: "CO2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sensors with classes should not need names that are essentially the same as the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
| name: switch | ||
| type: boolean | ||
| - entity: switch | ||
| name: "Child Lock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standard pattern is to use a lock entity for this:
- entity: lock
translation_key: child_lock
category: config
dps:
- id: 111
type: boolean
name: lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
|
|
||
| # Configuration entities | ||
| - entity: switch | ||
| name: "Night Mode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think translaton_key: sleep can be used here instead of this name and icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
| - id: 111 | ||
| name: switch | ||
| type: boolean | ||
| - entity: select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a light entity, with dp name brightness, and values mapped to 0, 128, 255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
| name: switch | ||
| type: boolean | ||
| - entity: switch | ||
| name: "Filter Reset" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a button entity, with translation_key: filter_reset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
| type: integer | ||
| unit: "°C" | ||
| - entity: sensor | ||
| name: "Outdoor Temperature" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HA naming convention is to only capitalise the first word of entity and device names (unless abbreviations or branding is involved)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
|
|
||
| # Diagnostic entities | ||
| - entity: sensor | ||
| name: "Heater Type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will never change, so probably not useful as a sensor. May be an attribute on another entity, especially if the value can be used to selectively enable features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is diagnostic information about the device's heater type. I couldn't find a suitable way to display it as a static label. It's included with hidden: true for completeness. This value is purely informational and cannot be used to enable or disable any device function, as all device configurations come with a heater.
| name: sensor | ||
| type: string | ||
| - entity: sensor | ||
| name: "CO2 Sensor Status" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should maybe just be an attribute of the CO2 sensor. Especially if it is just indicating whether the sensor is fitted or not, in which case it can be the available attribute with a mapping to true/false depending on value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
|
@make-all Please review |
(cherry picked / squashed from upstream PR make-all#4137)
Device: Tion Breezer Bio X
Product ID: 9mqdhwklpvnnvb7t
Link to product: https://tion.kz/product/breezer-tion-bio-x/