forked from github/codeql
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: [pull] main from github:main #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
552
commits into
majacQ:main
Choose a base branch
from
github:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… range analysis fails to deduce a bound.
C++: AST dataflow through smart pointers
…d for unanalyzable expressions. This hopefully means that expressions that do not satisfy these predicates will never overflow/underflow.
…ntal C++: Fix duplicate names in experimental queries
The recent change to `appliesTo` lead to a perturbation in the join order of this predicate, which resulted in a cartesian product between `call` and `ctx` being created (before being filtered by `appliesTo`). By splitting the intermediate result into its own helper predicate, suitably marked to prevent inlining/magic, we prevent this from happening again.
Actions: Add workflow for marking stale questions
In some cases, we were joining the result of `val.getClass()` against the first argument of `Types::improperSubclass` before filtering out the vast majority of tuples by the call to `isinstance_call`. To fix this, we let `isinstance_call` take care of figuring out the class of the value being tested. As a bonus, this cleans up the only other place where `isinstance_call` is used, where we _also_ want to know the class of the value being tested in the `isinstance` call.
…ctor C++: Refactor some side effect generation code
Approved by esbena
C#: Add `Customizations.qll`
…b.qll Co-authored-by: Chris Smowton <smowton@github.com>
Java: Query for detecting Jakarta Expression Language injections
…ype-crash Approved by erik-krogh
Java: convert sinks to CSV
Actions: Use the main branch of the codeql action
Java: Use separate data-flow copy for `PredictableSeedFlowConfiguration`
C++: IR Alias Analysis for smart pointers
The find-the-thief exercise is inconsistent. The first part lists 10 answered questions about the thief, but later discussion silently adds a new question as question 8, so there are a total of 11 answered questions. This commit updates the first list of answered questions so that it matches later discussions and the sample solution.
Approved by esbena
Limits the behaviour of #5614 in two ways: First, we only consider files that are contained in the source archive. This prevents unnecessary computation involving files in e.g. the standard library. Secondly, we ignore any relative imports (e.g. `from .foo import ...`), as these only work inside packages anyway. This fixes an observed performance regression on projects that include `google-cloud-sdk` as part of their source code.
C#: Add extraction error diagnostic query
Python: Limit absolute imports
Approved by esbena
…sync Fix inconsistency in the find-the-thief exercise
Actions: Fix code scanning workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⤵️ pull
auto-branch-delete:on-close
Delete branch when pull request gets closed
auto-merge:on-bpr-success
Auto-merge on passed branch protection rule
auto-merge-method:merge
Auto-merge with merge commit
C++
C#
changelog:fixed
Add this issue or pull request to fixed changelog section
changelog:security
Add this issue or pull request to security changelog section
documentation
Improvements or additions to documentation
enhancement
New feature or request
Java
JS
Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )