Alert & Button done #2
Conversation
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Button</title> | ||
| <link rel="stylesheet" href="button.css"> | ||
| <style> |
There was a problem hiding this comment.
yeah that was only for display purposes, it does not affect the component
button/button.css
Outdated
| } | ||
| .btn-hover.btn-outline-success:hover { | ||
| background-color: var(--success); | ||
| color: white; |
There was a problem hiding this comment.
Instead of writing 'color:white' in individual classes, you can write in one line by calling all classnames separated with commas
There was a problem hiding this comment.
or you can add all the colors in main class(root)
There was a problem hiding this comment.
thanks, I'll do that
There was a problem hiding this comment.
Instead of writing 'color:white' in individual classes, you can write in one line by calling all classnames separated with commas
DONE
button/button.html
Outdated
| </div> | ||
|
|
||
| <div> | ||
| <button class="btn btn-secondary"><img src="download_white_24dp.svg" alt=""></button> |
There was a problem hiding this comment.
Please provide alt value for accessibility.
There was a problem hiding this comment.
Please provide alt value for accessibility.
DONE
specified white font color for the entire class, gave alt text
Please review the alert and button components