OSSM-870 Fix ApplyServiceMeshCRDs function #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewertow
reviewed
Dec 20, 2021
| pushd "${dir}" | ||
| git checkout "${UPDATE_BRANCH}" | ||
| popd | ||
|
|
||
| # FIXME: https://issues.redhat.com/browse/MAISTRA-2353 |
There was a problem hiding this comment.
What about this issue? Are we going to copy all of maistra CRDs?
There was a problem hiding this comment.
no - as I commented on the issue, I don't think it makes sense to do that. we should discuss in the team what we want to do and then remove the FIXME when we address the issue.
jewertow
approved these changes
Dec 20, 2021
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 2, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 4, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 4, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 9, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 11, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 21, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 22, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 28, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Mar 1, 2022
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Mar 1, 2022
maistra-bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.