Skip to content

Conversation

@YordanSoares
Copy link

mainwp-key-maker.php

readme.txt

  • Added "Tested up to: 5.4". We can limit the "Tested up to:" to just the major release (e.g. 5.4). The repository will automatically add the latest minor version as plugins shouldn’t break with a minor update.

*mainwp-key-maker.php*
- Added the same "Requires at least" of MainWP Dashboard.
- Because "Requires at least" is below 4.6. we need to set a Text Domain in mainwp-key-maker.php and it needs to be mainwp-key-maker to correctly internationalize the plugin. (More info: https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains)
- Setting a License header is mandatory for new plugins since April 2020. Consider adding one, preferably the same one as WordPress itself: “GPLv2 or later” (More info: https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/#1-plugins-must-be-compatible-with-the-gnu-general-public-license)

*readme.txt*
- Added "Tested up to: 5.4". We can limit the "Tested up to:" to just the major release (e.g. 5.4). The repository will automatically add the latest minor version as plugins shouldn’t break with a minor update.
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant