Bugfix/fee estimate rounding (#210)

* fix fee extimate rounding issue

* re fee rounding

* Apply formatting changes

---------

Co-authored-by: 2qx <2qx@users.noreply.github.com>

demo/min/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mainnet-cash/demo-min",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "private": true,
   "main": "index.js",
   "license": "MIT",
@@ -9,7 +9,7 @@
     "publish:public": "echo 'noop'"
   },
   "dependencies": {
-    "@mainnet-cash/contract": "2.3.12"
+    "@mainnet-cash/contract": "2.3.13"
   },
   "devDependencies": {
     "webpack": "5.58.1",

demo/react-next/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-next",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "private": true,
   "scripts": {
     "dev": "next dev",
@@ -15,7 +15,7 @@
     "@types/react-dom": "18.0.10",
     "eslint": "8.32.0",
     "eslint-config-next": "13.1.2",
-    "mainnet-js": "2.3.12",
+    "mainnet-js": "2.3.13",
     "next": "13.1.2",
     "react": "18.2.0",
     "react-dom": "18.2.0",

demo/vue-nuxt/package.json

@@ -13,8 +13,8 @@
     "rollup-plugin-node-polyfills": "^0.2.1"
   },
   "dependencies": {
-    "mainnet-js": "2.3.12",
-    "@mainnet-cash/indexeddb-storage": "2.3.12"
+    "mainnet-js": "2.3.13",
+    "@mainnet-cash/indexeddb-storage": "2.3.13"
   },
-  "version": "2.3.12"
+  "version": "2.3.13"
 }

demo/vue-vite/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vue-vite",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "scripts": {
     "dev": "vite",
     "build": "run-p type-check build-only",
@@ -13,8 +13,8 @@
     "lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore"
   },
   "dependencies": {
-    "mainnet-js": "2.3.12",
-    "@mainnet-cash/indexeddb-storage": "2.3.12",
+    "mainnet-js": "2.3.13",
+    "@mainnet-cash/indexeddb-storage": "2.3.13",
     "vue": "^3.2.37",
     "vue-router": "^4.1.2"
   },

demo/vue3/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mainnet-cash/demo",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "private": true,
   "scripts": {
     "serve": "vue-cli-service serve",
@@ -13,7 +13,7 @@
   "dependencies": {
     "core-js": "^3.6.5",
     "electrum-cash": "^2.0.8",
-    "mainnet-js": "2.3.12",
+    "mainnet-js": "2.3.13",
     "register-service-worker": "^1.7.1",
     "vue": "^3.0.0",
     "vue-router": "^4.0.0-0"

package.json

@@ -20,7 +20,7 @@
       "**/jest-runner/**"
     ]
   },
-  "version": "2.3.12",
+  "version": "2.3.13",
   "homepage": "https://mainnet.cash",
   "scripts": {
     "api:validate": "docker run --rm -v ${PWD}:/local openapitools/openapi-generator-cli:v6.2.1 validate -i /local/swagger/v1/api.yml",

packages/contract/package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "@mainnet-cash/contract",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "module": "dist/module/index.js",
   "types": "dist/module/index.d.ts",
   "exports": {
@@ -14,7 +14,7 @@
     "assert": "^2.1.0",
     "cashc": "^0.8.0",
     "cashscript": "^0.8.0",
-    "mainnet-js": "2.3.12",
+    "mainnet-js": "2.3.13",
     "pako": "^2.1.0",
     "util": "^0.12.5"
   },

packages/indexeddb-storage/package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "@mainnet-cash/indexeddb-storage",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "module": "dist/module/index.js",
   "types": "dist/module/index.d.ts",
   "exports": {
@@ -11,7 +11,7 @@
   "author": "readcash",
   "dependencies": {
     "dexie": "^3.2.4",
-    "mainnet-js": "2.3.12"
+    "mainnet-js": "2.3.13"
   },
   "devDependencies": {
     "fake-indexeddb": "^3.1.2"

packages/mainnet-cash/api/openapi.yaml

@@ -12,7 +12,7 @@ info:
     url: https://github.com/mainnet-cash/mainnet-js/blob/master/LICENSE
   termsOfService: https://mainnet.cash/terms/
   title: Mainnet Cash
-  version: 2.3.12
+  version: 2.3.13
 externalDocs:
   description: Find out more about mainnet-js
   url: https://mainnet.cash

packages/mainnet-cash/package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "mainnet-cash",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "description": "A developer friendly bitcoin cash wallet api  This API is currently in active development, breaking changes may be made prior to official release of version 1.  **Important:** This library is in active development ",
   "module": "index.js",
   "scripts": {
@@ -17,8 +17,8 @@
   "license": "MIT",
   "private": true,
   "dependencies": {
-    "@mainnet-cash/contract": "2.3.12",
-    "@mainnet-cash/postgresql-storage": "2.3.12",
+    "@mainnet-cash/contract": "2.3.13",
+    "@mainnet-cash/postgresql-storage": "2.3.13",
     "body-parser": "^1.19.0",
     "camelcase": "^5.3.1",
     "connect-timeout": "^1.9.0",
@@ -28,7 +28,7 @@
     "express-openapi-validator": "3.17.2",
     "express-rate-limit": "^5.2.3",
     "js-yaml": "^3.3.0",
-    "mainnet-js": "2.3.12",
+    "mainnet-js": "2.3.13",
     "ono": "^5.0.1",
     "openapi-sampler": "^1.0.0-beta.15",
     "patch-package": "^6.5.0",

packages/mainnet-js/package.json

@@ -9,7 +9,7 @@
     "url": "https://github.com/mainnet-cash/mainnet-js/issues"
   },
   "name": "mainnet-js",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "homepage": "https://mainnet.cash",
   "module": "dist/module/index.js",
   "browser": {

packages/mainnet-js/src/transaction/Wif.ts

@@ -484,7 +484,9 @@ export async function getFeeAmountSimple({
     sendRequests.reduce((prev, curr) => prev + outputSize(curr), 0) +
     (discardChange ? 0 : outputSizeP2pkh);
 
-  return (inputTotalSize + outputTotalSize + 16) * relayFeePerByteInSatoshi;
+  return Math.ceil(
+    (inputTotalSize + outputTotalSize + 16) * relayFeePerByteInSatoshi
+  );
 }
 
 // precise fee estimation
@@ -520,7 +522,7 @@ export async function getFeeAmount({
         changeAddress: "",
       });
 
-    return draftTransaction.length * relayFeePerByteInSatoshi + 1;
+    return Math.ceil(draftTransaction.length * relayFeePerByteInSatoshi + 1);
   } else {
     throw Error(
       "The available inputs in the wallet cannot satisfy this send request"

packages/postgresql-storage/package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "@mainnet-cash/postgresql-storage",
-  "version": "2.3.12",
+  "version": "2.3.13",
   "module": "dist/module/index.js",
   "types": "dist/module/index.d.ts",
   "exports": {
@@ -11,7 +11,7 @@
   "author": "readcash",
   "dependencies": {
     "axios": "^0.21.1",
-    "mainnet-js": "2.3.12",
+    "mainnet-js": "2.3.13",
     "parse-database-url": "^0.3.0",
     "pg": "^8.11.3",
     "pg-format": "^1.0.4"

swagger/v1/api.yml

@@ -12,7 +12,7 @@ info:
     url: https://github.com/mainnet-cash/mainnet-js/blob/master/LICENSE
   termsOfService: https://mainnet.cash/terms/
   title: Mainnet Cash
-  version: 2.3.12
+  version: 2.3.13
 externalDocs:
   description: Find out more about mainnet-js
   url: https://mainnet.cash