Skip to content

Implemented ability to add build tags only to generator via -gen_build_flags #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reddiridabl666 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implemented ability to add build tags only to generator via -gen_build_flags #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions bootstrap/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,19 @@ import (
"path/filepath"
"regexp"
"sort"
"strings"
)

const genPackage = "github.com/mailru/easyjson/gen"
const pkgWriter = "github.com/mailru/easyjson/jwriter"
const pkgLexer = "github.com/mailru/easyjson/jlexer"
const (
genPackage = "github.com/mailru/easyjson/gen"
pkgWriter = "github.com/mailru/easyjson/jwriter"
pkgLexer = "github.com/mailru/easyjson/jlexer"
)

var buildFlagsRegexp = regexp.MustCompile("'.+'|\".+\"|\\S+")
var (
buildFlagsRegexp = regexp.MustCompile("'.+'|\".+\"|\\S+")
tagsBuildFlagRegexp = regexp.MustCompile("^-?-tags=")
)

type Generator struct {
PkgPath, PkgName string
Expand Down Expand Up @@ -158,6 +164,21 @@ func (g *Generator) writeMain() (path string, err error) {
return dest, os.Rename(src, dest)
}

func findBuildTags(buildFlags []string) string {
for _, flag := range buildFlags {
prefix := tagsBuildFlagRegexp.FindString(flag)

if prefix == "" {
continue
}

res, _ := strings.CutPrefix(flag, prefix)

return " " + strings.ReplaceAll(res, ",", " ")
}
return ""
}

func (g *Generator) Run() error {
if err := g.writeStub(); err != nil {
return err
Expand Down Expand Up @@ -185,9 +206,11 @@ func (g *Generator) Run() error {
execArgs := []string{"run"}
if g.GenBuildFlags != "" {
buildFlags := buildFlagsRegexp.FindAllString(g.GenBuildFlags, -1)
g.BuildTags += findBuildTags(buildFlags)
execArgs = append(execArgs, buildFlags...)
}
execArgs = append(execArgs, "-tags", g.BuildTags, filepath.Base(path))

cmd := exec.Command("go", execArgs...)

cmd.Stdout = f
Expand Down