Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work without ML deps; seems like a circular import issue #131

Open
alexei opened this issue Mar 9, 2017 · 0 comments · May be fixed by #200
Open

Doesn't work without ML deps; seems like a circular import issue #131

alexei opened this issue Mar 9, 2017 · 0 comments · May be fixed by #200

Comments

@alexei
Copy link

alexei commented Mar 9, 2017

See also #130

I tried manually installing the deps (all except numpy, scipy, scikit-learn) in order to use the bruteforce method of extracting signatures, an attempt which results in the following:

>>> from talon.signature.bruteforce import extract_signature
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/Users/alexei/.virtualenvs/project/lib/python2.7/site-packages/talon/signature/__init__.py", line 26, in <module>
    from . import extraction
  File "/Users/alexei/.virtualenvs/project/lib/python2.7/site-packages/talon/signature/extraction.py", line 7, in <module>
    import numpy
ImportError: No module named numpy

After installing the numpy package, I get the following:

>>> from talon.signature.bruteforce import extract_signature
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/Users/alexei/.virtualenvs/project/lib/python2.7/site-packages/talon/signature/__init__.py", line 26, in <module>
    from . import extraction
ImportError: cannot import name extraction

Looks like a circular import issue.

andersk added a commit to andersk/talon that referenced this issue Oct 3, 2019
The nonstandard `setup.py install --no-ml` option didn’t work
correctly with pip.  We could move the ML dependencies into an extra,
but that approach was previously rejected (mailgun#121): extras can’t be
enabled by default, so it could have been disruptive to existing
users.  Instead, we split off a new talon-core package with no ML
dependencies, and have talon re-export everything from it.

Fixes mailgun#130; fixes mailgun#131.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk linked a pull request Oct 3, 2019 that will close this issue
andersk added a commit to andersk/talon that referenced this issue Oct 3, 2019
The nonstandard `setup.py install --no-ml` option didn’t work
correctly with pip.  We could move the ML dependencies into an extra,
but that approach was previously rejected (mailgun#121): extras can’t be
enabled by default, so it could have been disruptive to existing
users.  Instead, we split off a new talon-core package with no ML
dependencies, and have talon re-export everything from it.

Fixes mailgun#130; fixes mailgun#131.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk added a commit to andersk/talon that referenced this issue Jul 30, 2022
The nonstandard `setup.py install --no-ml` option didn’t work
correctly with pip.  We could move the ML dependencies into an extra,
but that approach was previously rejected (mailgun#121): extras can’t be
enabled by default, so it could have been disruptive to existing
users.  Instead, we split off a new talon-core package with no ML
dependencies, and have talon re-export everything from it.

Fixes mailgun#130; fixes mailgun#131.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants