-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work without ML deps; seems like a circular import issue #131
Comments
andersk
added a commit
to andersk/talon
that referenced
this issue
Oct 3, 2019
The nonstandard `setup.py install --no-ml` option didn’t work correctly with pip. We could move the ML dependencies into an extra, but that approach was previously rejected (mailgun#121): extras can’t be enabled by default, so it could have been disruptive to existing users. Instead, we split off a new talon-core package with no ML dependencies, and have talon re-export everything from it. Fixes mailgun#130; fixes mailgun#131. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/talon
that referenced
this issue
Oct 3, 2019
The nonstandard `setup.py install --no-ml` option didn’t work correctly with pip. We could move the ML dependencies into an extra, but that approach was previously rejected (mailgun#121): extras can’t be enabled by default, so it could have been disruptive to existing users. Instead, we split off a new talon-core package with no ML dependencies, and have talon re-export everything from it. Fixes mailgun#130; fixes mailgun#131. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/talon
that referenced
this issue
Jul 30, 2022
The nonstandard `setup.py install --no-ml` option didn’t work correctly with pip. We could move the ML dependencies into an extra, but that approach was previously rejected (mailgun#121): extras can’t be enabled by default, so it could have been disruptive to existing users. Instead, we split off a new talon-core package with no ML dependencies, and have talon re-export everything from it. Fixes mailgun#130; fixes mailgun#131. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See also #130
I tried manually installing the deps (all except numpy, scipy, scikit-learn) in order to use the bruteforce method of extracting signatures, an attempt which results in the following:
After installing the numpy package, I get the following:
Looks like a circular import issue.
The text was updated successfully, but these errors were encountered: