Test mode implementation, #24 #66
Conversation
|
@sixfeetover @michaelrkn Any ideas on this? |
|
This looks great! Thanks @pirogoeth! |
lib/mailgun/response.rb
Outdated
| } | ||
| end | ||
|
|
||
| self.new resp |
There was a problem hiding this comment.
Can I suggest using an OpenStruct here? Then if there ever was a time where you wanted more than body and code methods, you'll get them for free.
require 'ostruct`
self.new OpenStruct.new(h)Whatever key values you pass into the from_hash method will be callable without checking if the key exists and defining a method for it if it does.
There was a problem hiding this comment.
Oh absolutely! Thanks!
|
This looks great, thank you. 👍 |
| api_version = 'v3', | ||
| ssl = true) | ||
| ssl = true, | ||
| test_mode = false) |
There was a problem hiding this comment.
Should this default to Mailgun.test_mode?
There was a problem hiding this comment.
@kpandya91 So actually that's a really good point. It looks like Mailgun.test_mode was defined in an earlier commit but was never actually used? So this actually could make use of that field. I'll dig through the code again to make sure it's unused and add that as the default value. Thanks!
5 participants
Super basic implementation of a "test mode" allowing users to easily stub calls that send emails.
Initially, it is just for stubbing the message sending routine, but can be expanded to stub other API calls if necessary.
Test mode is also tested. 😂
EDIT: Version has also been bumped to 1.1.2 for this feature.