Preserve subscriptions during ZooKeeper failover (fixes #26) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horkhe
force-pushed
the
maxim/develop
branch
2 times, most recently
from
4567656 to
eeaada1
Compare
horkhe
added a commit
that referenced
this pull request
Oct 1, 2015
Preserve subscriptions during ZooKeeper failover (fixes #26)
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found in production that when a ZooKeeper leader dies, Kafka-Pixy loses all claims for partitions that it made, but keeps consuming them and committing offsets. However the first Kafka-Pixy instance started after failover will see that no partitions are claimed, claim them all and start consuming messages and committing offsets for partitions that are still owned by other instances, resulting in duplicate consumption.
Investigation revealed that the reason for that is an issue with samuel/go-zookeeper library. The issue was fixed in the mailgun clone of that library. This change switches to use the mailgun/go-zookeeper clone of the library while a PR against upstream is pending.
EDIT: The PR against go-zookeeper has been accepted, but I decided to keep dependency on the mailgun clone for the time being in case we need to fix something else.