Add custom http client support #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Closed
stek29
reviewed
Oct 29, 2021
bot.go
Outdated
| // All communications with bot API must go through Bot struct. | ||
| // In general you don't need to configure this bot, therefore all options are optional arguments. | ||
| func NewBot(token string, opts ...BotOption) (*Bot, error) { | ||
| func NewBot(client *http.Client, token string, opts ...BotOption) (*Bot, error) { |
There was a problem hiding this comment.
IMO This would be backward incompatible and would require a new release
There was a problem hiding this comment.
Indeed. Add support for custom http client passed to as opts to maintain backward compatibility.
DmitryDorofeev
approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17