-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more checks to scripts and output more system information #1456
base: main
Are you sure you want to change the base?
Conversation
Overall, I like it. I personally like the section also where you're providing extra info like architecture/GPU/etc - just not sure if others would find it useful? |
@JoshData, I'm not sure of the stylistic choices you prefer. Please let us know. :) |
@zatricky Thanks again for your review and feedback.
Almost all the extra system information was used is the script (Linux distribution, CPU cores, architecture, total RAM, total swap space, computer name and time zone), but was not output, which is why I said it is for "user verification". The rest (CPU, GPU, container and VM hypervisor) is useful for debugging and when users create issues. The information is also interesting to know when you are deploying Mail-in-a-Box on an unfamiliar cloud VM. |
My only nitpick is the variable name for bit size. I like it overall. The rest is up to Josh. :) |
Edit: This PR is now very outdated, but I would be happy to update it if there is ever interest in making these improvements.
Added temporary message to direct Ubuntu 18.04 users to the corresponding branch.NONINTERACTIVE
users that is more secure than12345678
.lsb_release
command, since it is not installed in all Linux distributions by default.bc
andexpr
commands, since Bash can do math natively.This pull request was originally part of #1435.